Remove the native go helper
#5521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
remove-redundant-git-url-for-path
branch
from
3f299d2
to
a0e5b38
Compare
jeffwidman
force-pushed
the
remove-redundant-git-url-for-path
branch
from
a0e5b38
to
3609c87
Compare
There are two functions that do the same thing, one in `ruby` and one in `go`. TODO explain why we had them both and why safe to remove the `go` one once I finish researching it. So I removed the one written in `go`. It turns out this function was the only reason we had native `go` helpers, so I was able to completely remove the helpers infra altogether. Fix dependabot#4448
jeffwidman
force-pushed
the
remove-redundant-git-url-for-path
branch
from
3609c87
to
e509114
Compare
|
This needs to be rebased to the new Dockerfile location, but before I do that, I want to investigate the underlying problem a bit more, as when I last left it I was starting to think we actually should prefer using the native |
|
We went the other way and dropped the ruby implementation instead: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two functions that do the same thing, one in
rubyand one ingo.TODO explain why we had them both and why safe to remove the
gooneonce I finish researching it.
So I removed the one written in
go.It turns out this function was the only reason we had native
gohelpers, so I was able to completely remove the helpers infra altogether.
Fix #4448